Hey @azaozz - The main issue here is that you end up with both modals open at the same time when using the shortcut key from within the classic block:

Not sure if there's a way to stop the gutenberg help opening.

I'm also wondering if it might be a bit confusing for users if there are inconsistent modals. If the title of the classic editor modal could be changed to something like 'Classic Block shortcuts' that might help.

Ah, I see. We should be able to fix this by "capturing" the key event in the wordpress plugin (stopPropagation, etc.). Lets see how we can do that in TinyMCE :)

Actually it may be good to do that for all TinyMCE shortcuts so they don't trigger something "upstream" when an MCE instance is focused.

If the title of the classic editor modal could be changed...

Yep, shouldn't be hard to do that, just need a "sure" way to detect when we are in the classic block instance.

Hmm, thinking more about this, it would be better to have just one "help modal". How about adding another section to the main Gutenberg modal for the Classic Block? Then can list just the specific shortcuts there, not repeat most of them :)

The current Gutenberg modal is getting pretty big, so it might need some thought on how to keep it easily navigable if we add more sections to it.

True, it's quite long even now :) Would need to look at making it two columns perhaps? Thinking something like that would probably be good?

Closes #9748

I don't think we should add more sections to the existing modal. It is ok to have 2 modals but it's not ok to show them both together. Classic is very specific and unless mistaken as to what is being suggested, it would be weird to see that information in the non-classic modal.

We could override the shortcut if the classic block is selected?

@karmatosed Sure. Still thinking we could try making the "global" help popup responsive, i.e. switch to two columns when the viewport is wide enough, perhaps in v.2?

There may also be other blocks that have specific shortcuts. Thinking we may need an "uniform" way to display them? One thing I tried (just visually) was to move the "button" that opens the global popup to the "More options" menu on the block toolbar. May be nice to have it there, and we can tweak the content according to block type :)

@iseulde yeah, will need to override the shortcut in the Classic Block instance. Was wondering if we need to override all TinyMCE shortcuts so they don't trigger something else "upstream" when an instance is focused. Will also change the title to "Classic Block Keyboard Shortcuts" as discussed above.

will need to override the shortcut in the Classic Block instance

That means part of the fix for this will be in the wordpress TinyMCE plugin in core. Created https://core.trac.wordpress.org/ticket/45365 for it.